Skip to content

Commit 346fe67

Browse files
committed
Clarify proper fraction implementation
1 parent ede74a2 commit 346fe67

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
// execute the code to ensure all tests pass.
1212

1313
function isProperFraction(numerator, denominator) {
14-
return numerator >= 0 && denominator > 0 && numerator < denominator;
14+
return numerator > 0 && denominator > 0 && numerator < denominator;
1515
}
1616

1717
// The line below allows us to load the isProperFraction function into tests in other files.
@@ -38,3 +38,4 @@ assertEquals(isProperFraction(2, 2), false);
3838
assertEquals(isProperFraction(5, 2), false);
3939
assertEquals(isProperFraction(-1, 2), false);
4040
assertEquals(isProperFraction(1, 0), false);
41+
assertEquals(isProperFraction(0, 5), false);

0 commit comments

Comments
 (0)