Skip to content

chore: 🤖 expose types which are consumed publicly#896

Merged
punkbit merged 3 commits intomainfrom
chore/expose-narrow-asset-types
Mar 9, 2026
Merged

chore: 🤖 expose types which are consumed publicly#896
punkbit merged 3 commits intomainfrom
chore/expose-narrow-asset-types

Conversation

@punkbit
Copy link
Collaborator

@punkbit punkbit commented Mar 9, 2026

Why?

Expose narrow asset types from public API: LogoName, LogoProps, FlagName, FlagProps, TextFieldProps

How?

  • Updates public exports

Preview?

N/A

@changeset-bot
Copy link

changeset-bot bot commented Mar 9, 2026

🦋 Changeset detected

Latest commit: 4544049

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@clickhouse/click-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link

github-actions bot commented Mar 9, 2026

Claude finished @punkbit's task in 1m 9s —— View job


Code Review

  • Gather context
  • Review changed files
  • Post findings

✅ Looks great! No issues found — nice work!

The three additions are clean and consistent with the existing export patterns:

  • FlagName / FlagProps are exported directly after the Flag component export (line 29–30), matching the convention comment at the top of index.ts.
  • LogoName / LogoProps follow the same pattern right after Logo (line 29–30 in the Assets section).
  • TextFieldProps is added alongside the other *FieldProps types in the Text Field section (line 254), keeping the group consistent.

The source types themselves are well-typed (FlagProps/LogoProps extend SVGAttributes<SVGElement> with proper named fields), and TextFieldProps is already defined as a proper exported interface in TextField.tsx. No regressions, no breaking changes — just expanding the public surface area as intended.

The changeset is correctly marked as patch.

@github-actions
Copy link

github-actions bot commented Mar 9, 2026

Claude finished @punkbit's task in 41s —— View job


Code Review

  • Gather context
  • Review changed files
  • Post findings

✅ Looks great! No issues found — nice work!

The three export additions are clean and consistent:

  • FlagName / FlagProps — exported from the correct source (Flags/system/types.ts), where FlagProps properly extends SVGAttributes<SVGElement> with typed name, theme, and size fields.
  • LogoName / LogoProps — same pattern, same correctness (Logos/system/types.ts).
  • TextFieldProps — exported directly from TextField.tsx where it's defined as a proper export interface. Placement alongside the other *FieldProps exports in src/index.ts is consistent.

No regressions, no breaking changes, changeset is correctly marked as patch.

@workflow-authentication-public
Copy link
Contributor

📚 Storybook Preview Deployed

✅ Preview URL: https://click-8sbk9i9wy-clickhouse.vercel.app

Built from commit: e228dce0716fcf80fb3bfbb197f86d5b4a69066f

@punkbit punkbit merged commit 1f6cda6 into main Mar 9, 2026
8 checks passed
@punkbit punkbit deleted the chore/expose-narrow-asset-types branch March 9, 2026 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants