BUG: Plugin logs SQL queries when WP_DEBUG_LOG = false

[alebedev80]

Plugin logs SQL queries when WP_DEBUG_LOG = false

Issue

The plugin is logging SQL queries to the error log even when WP_DEBUG_LOG is set to false.

Expected behavior

When WP_DEBUG_LOG = false, no debug information should be logged.

Current behavior

SQL queries are being logged on every request:

SELECT 0 AS is_personal, 1 AS is_ip, status, country_code, network, mask
FROM wp_spbc_firewall_data_v4
WHERE network IN (3288334336,3321888768,3322413056,3322675200,3322707968,3322724352,3322732544,3322736640,3322737664,3322738176,3322738240,3322738272,3322738276,3322738278)
    AND network = 3322738278 & mask
    AND country_code = "0"
) UNION ...

Stack trace:

made by require('wp-load.php'), require_once('wp-config.php'), require_once('wp-settings.php'), do_action('init'), WP_Hook->do_action, WP_Hook->apply_filters, {closure}, spbc_firewall__check, CleantalkSP\Security\Firewall->run, CleantalkSP\SpbctWP\Firewall\FW->check, CleantalkSP\SpbctWP\Firewall\FW->ipv4GetResultsFromDb, CleantalkSP\SpbctWP\DB->fetchAll

Request

Please disable error logging when WP_DEBUG_LOG = false.

[alexandergull]

Hello.

We will inspect this within a few days.

[Glomberg]

Hello, @alebedev80

SQL queries are being logged on every request:

Please, provide the full error message - is this the fatal error, or debug statement, or some one else...

[alebedev80]

@Glomberg

				SELECT 0 AS is_personal, 1 AS is_ip, status, country_code, network, mask
				FROM wp_spbc_firewall_data_v4
				WHERE network IN (3288334336,3321888768,3322413056,3322675200,3322707968,3322724352,3322732544,3322736640,3322737664,3322738176,3322738240,3322738272,3322738276,3322738278)
					AND network = 3322738278 & mask
					AND country_code = "0"
			) UNION (
				SELECT 1 AS is_personal, 1 AS is_ip, status, 0 AS country_code, network, mask
				FROM wp_spbc_firewall__personal_ips_v4
				WHERE network IN (3288334336,3321888768,3322413056,3322675200,3322707968,3322724352,3322732544,3322736640,3322737664,3322738176,3322738240,3322738272,3322738276,3322738278)
					AND network = 3322738278 & mask
			) UNION (
				SELECT 1 AS is_personal, 0 AS is_ip, tbl_private.status, country_code, network, mask
				FROM wp_spbc_firewall__personal_countries AS tbl_private
				RIGHT JOIN wp_spbc_firewall_data_v4 AS tbl_common USING(country_code)
				WHERE network IN (3288334336,3321888768,3322413056,3322675200,3322707968,3322724352,3322732544,3322736640,3322737664,3322738176,3322738240,3322738272,3322738276,3322738278)
					AND network = 3322738278 & mask
					AND tbl_private.status IS NOT NULL
					AND 32573 <> 0
			) made by require('wp-load.php'), require_once('wp-config.php'), require_once('wp-settings.php'), do_action('init'), WP_Hook->do_action, WP_Hook->apply_filters, {closure}, spbc_firewall__check, CleantalkSP\Security\Firewall->run, CleantalkSP\SpbctWP\Firewall\FW->check, CleantalkSP\SpbctWP\Firewall\FW->ipv4GetResultsFromDb, CleantalkSP\SpbctWP\DB->fetchAll

[Glomberg]

@alebedev80
Thank you!

Additional: What string printed before "SELECT 0 AS is_personal..."? (usually this my be Critical error, or Error notice). Is there some CleanTalk's debug information there? And, Is this message appears permanently?

And, please, try one step: go to the plugin settings, enable Complete deactivation setting in the bottom of advanced and reactivate the plugin/ Is the error still logged after that step?

[alebedev80]

@Glomberg sorry! my fail! i already created issue about that error but in another repo CleanTalk/wordpress-antispam#604 (comment)

[01-Sep-2025 14:41:28 UTC] WordPress database error Table 'lox24_cms3.wp_spbc_firewall_data_v4' doesn't exist for query (
                                SELECT 0 AS is_personal, 1 AS is_ip, status, country_code, network, mask
                                FROM wp_spbc_firewall_data_v4
                                WHERE network IN (3288334336,3321888768,3322413056,3322675200,3322707968,3322724352,3322732544,3322736640,3322737664,3322738176,3322738240,3322738272,3322738276,3322738278)
                                        AND network = 3322738278 & mask
                                        AND country_code = "0"
                        ) UNION (
                                SELECT 1 AS is_personal, 1 AS is_ip, status, 0 AS country_code, network, mask
                                FROM wp_spbc_firewall__personal_ips_v4
                                WHERE network IN (3288334336,3321888768,3322413056,3322675200,3322707968,3322724352,3322732544,3322736640,3322737664,3322738176,3322738240,3322738272,3322738276,3322738278)
                                        AND network = 3322738278 & mask
                        ) UNION (
                                SELECT 1 AS is_personal, 0 AS is_ip, tbl_private.status, country_code, network, mask
                                FROM wp_spbc_firewall__personal_countries AS tbl_private
                                RIGHT JOIN wp_spbc_firewall_data_v4 AS tbl_common USING(country_code)
                                WHERE network IN (3288334336,3321888768,3322413056,3322675200,3322707968,3322724352,3322732544,3322736640,3322737664,3322738176,3322738240,3322738272,3322738276,3322738278)
                                        AND network = 3322738278 & mask
                                        AND tbl_private.status IS NOT NULL
                                        AND 32573 <> 0
                        ) made by require('wp-load.php'), require_once('wp-config.php'), require_once('wp-settings.php'), do_action('init'), WP_Hook->do_action, WP_Hook->apply_filters, {closure}, spbc_firewall__check, CleantalkSP\Security\Firewall->run, CleantalkSP\SpbctWP\Firewall\FW->check, CleantalkSP\SpbctWP\Firewall\FW->ipv4GetResultsFromDb, CleantalkSP\SpbctWP\DB->fetchAll

[Glomberg]

@alebedev80

Thank you, it is a little bit clearer.

Lets continue the investigation.

1. Is this error appears every hit all time or appears several error at the limited time range of the day? How still it often?
2. Did you tried reinstal the plugin using the complete deactivation? This action will help to recreate the tables.

[alebedev80]

@Glomberg that type of errors in your CleanTalk products relates to plugin upgrade functionality when table removes from db. Please check CleanTalk/wordpress-antispam#604 (comment)

[Glomberg]

Hello @alebedev80 ,

Please disable error logging when WP_DEBUG_LOG = false.

It is impossible from our side, because the error triggers by class wpdb https://github.com/WordPress/WordPress/blob/6.8.2/wp-includes/class-wpdb.php#L1823 There is no check WP_DEBUG.

[alebedev80]

@Glomberg The issue isn't related to logging functionality. The core problem is that your code drops database tables during the upgrade process without implementing proper state management for this transition period.

I've proposed a potential solution in this comment:

I think will be better to set some 'lock' (file, db or cache entity or whatever using in WP) before tables remove and remove that 'lock' on plugin upgrade done. when lock set handle request without error.

This approach would prevent the current issue where requests fail when tables are temporarily unavailable during upgrades.

[Glomberg]

@alebedev80 ,

The issue isn't related to logging functionality.

But your request is about disable error logging.

The core problem is that your code drops database tables during the upgrade process

The upgrade process is based on a queue way. I will aggree the process may be improved, and you suggested one resonable fix. And the developers team will implement this, you know about.

But, lets try one other way to prevent errors apearing. Just try to modify upgrade process to one flow, not queue. Plese, define constant SPBCT_FORCE_DIRECT_SECFW_UPDATE assigned true in your wp-config.php

define('SPBCT_FORCE_DIRECT_SECFW_UPDATE', true);

and follow the updating (during syncronization, for example).
Is the errors still appears?

[alebedev80]

lets try one other way to prevent errors appearing

@Glomberg what do you mean? suppress the errors but http request anyway will fail with code 500?

[Glomberg]

suppress the errors but http request anyway will fail with code 500?

Not suppressing, but trying to modify the upgrade process to try to prevent errors.

[alebedev80]

define('SPBCT_FORCE_DIRECT_SECFW_UPDATE', true);

i've added that setting to wp-config.php

[Glomberg]

Hello @alebedev80 ,

i've added that setting

Are there the new error messages?

[alebedev80]

@Glomberg No, but the issue appears to be quite rare since it requires a specific combination of events: upgrading the plugin and processing a request simultaneously.