Find player#149
Open
ah66396 wants to merge 2 commits into
Open
Conversation
Contributor
Author
|
based on issue Find a Player for a Team #95 |
Member
|
Is there a reason we need a new separate entity for Profile? |
Contributor
Author
|
actually there isnt, i noticed this when writing code for the frontend, the backend was essentially made when i was new to the codebase and i kinda just used that code. its probably better that i move the stuff to profile so that im not using 2 for on the frontend |
Member
|
Yeah I think it's probably better to add the new profile fields to the Player entity instead of creating a new entity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backend for social stuff