Skip to content

VIP does not return a proper response code #599

Description

@nbcsteveb

Expected/Desired Behavior

The status code returned by wp should be properly set, this helps with command chaining or handling failures.

$ wp ajsodjasiodjsaiod
Error: 'ajsodjasiodjsaiod' is not a registered wp command. See 'wp help' for available commands.

$ echo $?
1

$ vip @app.env wp ajsodjasiodjsaiod
Error: 'ajsodjasiodjsaiod' is not a registered wp command. See 'wp help' for available commands.

$ echo $?
1

Actual Behavior

$ wp ajsodjasiodjsaiod
Error: 'ajsodjasiodjsaiod' is not a registered wp command. See 'wp help' for available commands.

$ echo $?
1

$ vip @app.env wp ajsodjasiodjsaiod
Error: 'ajsodjasiodjsaiod' is not a registered wp command. See 'wp help' for available commands.

$ echo $?
0

Steps to Reproduce the Problem

  1. Step 1: Run a vip @app.env wp command that throws an error or otherwise returns an error status code through standard WP CLI.
  2. Step 2: Check the returned status code, and notice it is always "0".

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    [Status] KeepPrevent the "stale" workflow from auto-closing

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions