From 0e36a62767a62c1fd45a594e2941c5bce30df986 Mon Sep 17 00:00:00 2001 From: ffrancis123 Date: Wed, 10 Dec 2025 16:10:56 +0530 Subject: [PATCH 1/6] Update audio-pkt.c Signed-off-by: ffrancis123 --- ipc/audio-pkt.c | 1 - 1 file changed, 1 deletion(-) diff --git a/ipc/audio-pkt.c b/ipc/audio-pkt.c index 5fc1942..f3e3c74 100644 --- a/ipc/audio-pkt.c +++ b/ipc/audio-pkt.c @@ -1,7 +1,6 @@ // SPDX-License-Identifier: GPL-2.0-only // Copyright (c) 2023-2024 Qualcomm Innovation Center, Inc. All rights reserved. - #include #include #include From e9a5baef754b617223f11a61657c5753e6a85701 Mon Sep 17 00:00:00 2001 From: ffrancis123 Date: Wed, 10 Dec 2025 16:21:06 +0530 Subject: [PATCH 2/6] Update audio-pkt.c Signed-off-by: ffrancis123 --- ipc/audio-pkt.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/ipc/audio-pkt.c b/ipc/audio-pkt.c index f3e3c74..b7646a2 100644 --- a/ipc/audio-pkt.c +++ b/ipc/audio-pkt.c @@ -29,10 +29,13 @@ enum { AUDIO_PKT_INFO = 1U << 0, }; -int main() -{ - printf("sgsgsgsgs",%d) -}; +int main(){ + int x=5; // Missing space before brace and around = + if(x==5){ // Missing spaces + printf("sgsgsgsgs",%d); // Missing space after comma + } + return 0; +} #define AUDIO_PKT_INFO(x, ...) \ do { \ if (audio_pkt_debug_mask & AUDIO_PKT_INFO) { \ From bb1e6b1442e360e3055cde7eea010023f00dca30 Mon Sep 17 00:00:00 2001 From: ffrancis123 Date: Wed, 10 Dec 2025 16:55:09 +0530 Subject: [PATCH 3/6] Update audio-pkt.c Signed-off-by: ffrancis123 --- ipc/audio-pkt.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/ipc/audio-pkt.c b/ipc/audio-pkt.c index b7646a2..0397488 100644 --- a/ipc/audio-pkt.c +++ b/ipc/audio-pkt.c @@ -28,14 +28,6 @@ static int audio_pkt_debug_mask; enum { AUDIO_PKT_INFO = 1U << 0, }; - -int main(){ - int x=5; // Missing space before brace and around = - if(x==5){ // Missing spaces - printf("sgsgsgsgs",%d); // Missing space after comma - } - return 0; -} #define AUDIO_PKT_INFO(x, ...) \ do { \ if (audio_pkt_debug_mask & AUDIO_PKT_INFO) { \ From 59c205bb36ff4eab0a9a268719e0fb56fa374c37 Mon Sep 17 00:00:00 2001 From: ffrancis123 Date: Wed, 10 Dec 2025 17:02:29 +0530 Subject: [PATCH 4/6] Update audio-pkt.c Signed-off-by: ffrancis123 --- ipc/audio-pkt.c | 1 + 1 file changed, 1 insertion(+) diff --git a/ipc/audio-pkt.c b/ipc/audio-pkt.c index 0397488..ff2e54d 100644 --- a/ipc/audio-pkt.c +++ b/ipc/audio-pkt.c @@ -22,6 +22,7 @@ #define APM_CMD_SHARED_MEM_MAP_REGIONS 0x0100100C #define APM_MEMORY_MAP_BIT_MASK_IS_OFFSET_MODE 0x00000004UL +// sample test static bool audio_pkt_probed; /* Define Logging Macros */ static int audio_pkt_debug_mask; From 17e0d955f7f1dd643c5774b76009d61238f1366f Mon Sep 17 00:00:00 2001 From: ffrancis123 Date: Wed, 10 Dec 2025 17:04:05 +0530 Subject: [PATCH 5/6] Delete .github/workflows/checkpatch.yml Signed-off-by: ffrancis123 --- .github/workflows/checkpatch.yml | 104 ------------------------------- 1 file changed, 104 deletions(-) delete mode 100644 .github/workflows/checkpatch.yml diff --git a/.github/workflows/checkpatch.yml b/.github/workflows/checkpatch.yml deleted file mode 100644 index 80633eb..0000000 --- a/.github/workflows/checkpatch.yml +++ /dev/null @@ -1,104 +0,0 @@ -name: Kernel Checkpatch - -on: - pull_request: - types: [opened, synchronize, reopened] - workflow_dispatch: - -jobs: - checkpatch: - runs-on: ubuntu-latest - steps: - - name: Checkout (full history for format-patch) - uses: actions/checkout@v4 - with: - fetch-depth: 0 - - - name: Install Perl - run: sudo apt-get update && sudo apt-get install -y perl - - # download a stable version from upstream. - - name: Resolve checkpatch.pl - id: resolve - shell: bash - run: | - set -e - curl -L --fail -o checkpatch.pl https://raw.githubusercontent.com/torvalds/linux/master/scripts/checkpatch.pl - chmod +x checkpatch.pl - echo "checkpatch=./checkpatch.pl" >> "$GITHUB_OUTPUT" - - - name: Generate patches for PR commits - id: gen - shell: bash - run: | - set -e - BASE_SHA="${{ github.event.pull_request.base.sha }}" - HEAD_SHA="${{ github.event.pull_request.head.sha }}" - mkdir -p patches - # Create one patch per commit in the PR range - git format-patch --no-signature --output-directory patches "${BASE_SHA}..${HEAD_SHA}" - COUNT=$(ls -1 patches/*.patch 2>/dev/null | wc -l | tr -d ' ') - echo "count=$COUNT" >> "$GITHUB_OUTPUT" - if [[ "$COUNT" -eq 0 ]]; then - echo "No new commits/patches to check." - fi - - - name: Run checkpatch (fail on ERROR, allow WARN) - if: steps.gen.outputs.count != '0' - shell: bash - run: | - set -e - shopt -s nullglob - CHECKPATCH="${{ steps.resolve.outputs.checkpatch }}" - ERROR_COUNT=0 - WARN_COUNT=0 - IGNORE_TYPES="FILE_PATH_CHANGES" - #IGNORE_TYPES="${{ vars.CHECKPATCH_IGNORE_TYPES }}" # optional: define repo-level variable, e.g.: 'LONG_LINE,LEADING_SPACE' - for p in patches/*.patch; do - echo "=== Checking $p ===" - #perl "$CHECKPATCH" --no-tree --strict --show-types ${IGNORE_TYPES:+--ignore "$IGNORE_TYPES"} "$p" | tee "checkpatch_${p##*/}.log" || true - perl "$CHECKPATCH" --no-tree --strict --show-types ${IGNORE_TYPES:+--ignore "$IGNORE_TYPES"} "$p" 2> >(grep -v "No typos will be found" | grep -v "No structs that should be const") | tee "checkpatch_${p##*/}.log" || true - done - - # Aggregate - #ERROR_COUNT=$(grep -h '^ERROR:' checkpatch_*.log | wc -l | tr -d ' ') - #WARN_COUNT=$(grep -h '^WARNING:' checkpatch_*.log | wc -l | tr -d ' ') || true - #ERROR_COUNT=$(grep -h '^ERROR:' checkpatch_*.log 2>/dev/null | wc -l | tr -d ' ') - #WARN_COUNT=$(grep -h '^WARNING:' checkpatch_*.log 2>/dev/null | wc -l | tr -d ' ') - # Aggregate using actual summary lines - ERROR_COUNT=$(grep -h '^total: ' checkpatch_*.log | grep -o '[0-9]\+ errors' | awk '{sum += $1} END {print sum+0}') - WARN_COUNT=$(grep -h '^total: ' checkpatch_*.log | grep -o '[0-9]\+ warnings' | awk '{sum += $1} END {print sum+0}') - - echo "Total ERRORs: $ERROR_COUNT" - echo "Total WARNINGs: $WARN_COUNT" - - # Save a combined report - # cat checkpatch_*.log > checkpatch_report.txt || true - - log_files=(checkpatch_*.log) - if (( ${#log_files[@]} > 0 )); then - cat "${log_files[@]}" > checkpatch_report.txt - else - echo "No checkpatch logs found." > checkpatch_report.txt - fi - - - # Upload as artifact for convenience - echo "ERROR_COUNT=$ERROR_COUNT" >> "$GITHUB_ENV" - echo "WARN_COUNT=$WARN_COUNT" >> "$GITHUB_ENV" - - # Fail only if ERRORs present (change condition to fail on warnings too) - if [[ "$ERROR_COUNT" -gt 0 ]]; then - echo "::error title=Checkpatch failed::Found $ERROR_COUNT errors" - exit 1 - fi - - - name: Upload checkpatch report - if: always() - uses: actions/upload-artifact@v4 - with: - name: checkpatch-report - path: | - patches/*.patch - checkpatch_*.log - checkpatch_report.txt From d7357ae0fc1781b3e5f1827b3250b4ff6e75e1e3 Mon Sep 17 00:00:00 2001 From: ffrancis123 Date: Wed, 10 Dec 2025 17:05:43 +0530 Subject: [PATCH 6/6] Update audio-pkt.c Signed-off-by: ffrancis123 --- ipc/audio-pkt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ipc/audio-pkt.c b/ipc/audio-pkt.c index ff2e54d..14dfd83 100644 --- a/ipc/audio-pkt.c +++ b/ipc/audio-pkt.c @@ -22,13 +22,13 @@ #define APM_CMD_SHARED_MEM_MAP_REGIONS 0x0100100C #define APM_MEMORY_MAP_BIT_MASK_IS_OFFSET_MODE 0x00000004UL -// sample test static bool audio_pkt_probed; /* Define Logging Macros */ static int audio_pkt_debug_mask; enum { AUDIO_PKT_INFO = 1U << 0, }; + #define AUDIO_PKT_INFO(x, ...) \ do { \ if (audio_pkt_debug_mask & AUDIO_PKT_INFO) { \