removed redundant hit response in the middle, nsteps=1 is now default

Author: GiorgioAlbertoLucia

Detectors/Upgrades/ALICE3/IOTOF/simulation/include/IOTOFSimulation/DPLDigitizerParam.h

@@ -29,10 +29,9 @@ struct DPLDigitizerParam : public o2::conf::ConfigurableParamHelper<DPLDigitizer
   double timeOffset = 0.;                 ///< time offset (in seconds!) to calculate ROFrame from hit time
   int chargeThreshold = 75;               ///< charge threshold in Nelectrons
   int minChargeToAccount = 7;             ///< minimum charge contribution to account
-  int nSimSteps = 475;                    ///< number of steps in response simulation
+  int nSimSteps = 1;                      ///< number of steps in response simulation
   float energyToNElectrons = 1. / 3.6e-9; // conversion of eloss to Nelectrons
   int responseMatrixSize = 1;             ///< size of the response matrix (odd number)
-  bool performStepping = true;            ///< flag to perform stepping simulation
 
   std::string noiseFilePath{}; ///< optional noise masks file path. FIXME to be removed once switch to CCDBFetcher
 

Detectors/Upgrades/ALICE3/IOTOF/simulation/include/IOTOFSimulation/Digitizer.h

@@ -94,7 +94,6 @@ class Digitizer : public TObject
                       uint16_t row, uint16_t col, int nElectrons, o2::MCCompLabel& label);
 
   void stepping(const o2::itsmft::Hit& hit, float**& respMatrix, int& rowStart, int& colStart, int& rowSpan, int& colSpan);
-  void responseInTheMiddle(const o2::itsmft::Hit& hit, int& row, int& col);
 
   /// Apply time smearing to simulate detector resolution
   double smearTime(double time) const;

Detectors/Upgrades/ALICE3/IOTOF/simulation/src/Digitizer.cxx

@@ -136,37 +136,30 @@ void Digitizer::processHit(const o2::itsmft::Hit& hit, int evID, int srcID)
   const int roFrameAbs = 0; // For now, we can set this to 0 or calculate based on time if needed
   const int nROF = 1;       // For now, we can assume the signal is contained in one ROF, this can be extended to multiple ROFs based on the time
 
-  if (digitizerParams.performStepping) {
-    float** respMatrix = nullptr;
-    int rowStart = 0, colStart = 0, rowSpan = 0, colSpan = 0;
-    stepping(hit, respMatrix, rowStart, colStart, rowSpan, colSpan);
-
-    for (int irow = rowSpan; irow--;) {
-      uint16_t rowIS = irow + rowStart;
-      for (int icol = colSpan; icol--;) {
-        uint16_t colIS = icol + colStart;
-        float nEleResp = respMatrix[irow][icol];
-        if (!nEleResp) {
-          continue;
-        }
-        const int nElectronsSampled = gRandom->Poisson(electronsPerStep * nEleResp);
-        // Noise can be added here if needed
-
-        registerDigits(chip, roFrameAbs, smearedTime, nROF,
-                       static_cast<uint16_t>(rowIS), static_cast<uint16_t>(colIS), nElectronsSampled, label);
+  float** respMatrix = nullptr;
+  int rowStart = 0, colStart = 0, rowSpan = 0, colSpan = 0;
+  stepping(hit, respMatrix, rowStart, colStart, rowSpan, colSpan);
+
+  for (int irow = rowSpan; irow--;) {
+    uint16_t rowIS = irow + rowStart;
+    for (int icol = colSpan; icol--;) {
+      uint16_t colIS = icol + colStart;
+      float nEleResp = respMatrix[irow][icol];
+      if (!nEleResp) {
+        continue;
       }
-    }
+      const int nElectronsSampled = gRandom->Poisson(electronsPerStep * nEleResp);
+      // Noise can be added here if needed
 
-    for (int irow = 0; irow < rowSpan; ++irow) {
-      delete[] respMatrix[irow];
+      registerDigits(chip, roFrameAbs, smearedTime, nROF,
+                     static_cast<uint16_t>(rowIS), static_cast<uint16_t>(colIS), nElectronsSampled, label);
     }
-    delete[] respMatrix;
-  } else {
-    int row = 0, col = 0;
-    responseInTheMiddle(hit, row, col);
-    const int nElectronsSampled = gRandom->Poisson(charge);
-    registerDigits(chip, roFrameAbs, smearedTime, nROF, static_cast<uint16_t>(row), static_cast<uint16_t>(col), nElectronsSampled, label);
   }
+
+  for (int irow = 0; irow < rowSpan; ++irow) {
+    delete[] respMatrix[irow];
+  }
+  delete[] respMatrix;
 }
 
 void Digitizer::stepping(const o2::itsmft::Hit& hit, float**& respMatrix, int& rowStart, int& colStart, int& rowSpan, int& colSpan)
@@ -259,23 +252,6 @@ void Digitizer::stepping(const o2::itsmft::Hit& hit, float**& respMatrix, int& r
   }
 }
 
-void Digitizer::responseInTheMiddle(const o2::itsmft::Hit& hit, int& row, int& col)
-{
-  const auto& matrix = mGeometry->getMatrixL2G(hit.GetDetectorID());
-  const int chipID = hit.GetDetectorID();
-
-  math_utils::Vector3D<float> xyzPositionStart(matrix ^ (hit.GetPosStart())); // start position in sensor frame
-  math_utils::Vector3D<float> xyzPositionEnd(matrix ^ (hit.GetPos()));        // end position in sensor frame
-
-  // Calculate the middle position of the hit
-  math_utils::Vector3D<float> xyzPositionMiddle = (xyzPositionStart + xyzPositionEnd) * 0.5f;
-
-  if (!sSegmentation->localToDetector(xyzPositionMiddle.X(), xyzPositionMiddle.Z(), row, col, mGeometry->getIOTOFLayer(chipID))) {
-    LOG(debug) << "Hit position out of bounds for detector ID " << chipID;
-    return; // hit is outside the active area
-  }
-}
-
 //_______________________________________________________________________
 double Digitizer::smearTime(double time) const
 {